Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

feat: remove unused imports and update prettier #8336

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

aditya-mitra
Copy link
Collaborator

Summary

  • updated "prettier" to version 3
  • added "@ianvs/prettier-plugin-sort-imports" version 4.1.0
  • added "prettier-plugin-organize-imports" to remove unused imports
  • had first thought of using vscode's sortImports to remove unused imports when saving a file. But this might cause some problems with every save like import being lost when saved and before used OR bringing unwanted changes to a file when saving it.

References

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField added this pull request to the merge queue Jul 21, 2023
Merged via the queue into dev with commit 1a9c964 Jul 21, 2023
6 of 7 checks passed
@HexaField HexaField deleted the feat/remove-unused-imports-update-prettier branch July 21, 2023 06:39
"importOrder": ["<THIRD_PARTY_MODULES>", "^@etherealengine/(.*)$", "^@mui/(.*)$", "^[./]"],
"importOrderSeparation": true,
"importOrderSortSpecifiers": true,
"importOrderCaseInsensitive": true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some options removed by v4.0.0 's breaking changes here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants