Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Converted build_microk8s and build_minikube to buildx. #8395

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Converted build_microk8s and build_minikube to buildx. #8395

merged 1 commit into from
Jul 31, 2023

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Jul 29, 2023 •
edited
Loading

Summary

A summary of changes being made in this PR

References

closes EtherealEngine/ir-engine-launcher#83

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

hanzlamateen
hanzlamateen approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on microk8s and seems to be working fine

@barankyle barankyle added this pull request to the merge queue Jul 31, 2023
Merged via the queue into dev with commit 39795be Jul 31, 2023
8 checks passed
@barankyle barankyle deleted the local-docker-buildx branch July 31, 2023 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hanzlamateen hanzlamateen hanzlamateen approved these changes

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate docker build caching using buildx
2 participants
@barankyle @hanzlamateen