This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Updated instance-authorized-user migration. #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current state where not everything has been converted off of sequelize, some sequelize BelongsToMany (join table) associations are bugging because they are being made under new names without all of the required fields before the knex migration can create it properly. Specifically, instance_authorized_user was renamed to instance-authorized-user. The sequelize BelongsToMany relationship between user and instance is making a new instance-authorized-user table just based on that relationship, which doesn't know about the 'id' field. Then the knex migration tries to run, and fails because the instance-authorized-user table already exists. The deployment then has bugs because the table schema isn't correct. The solution was to make the migration delete the new table if it exists if it detects that the old table still exists. This probably needs to be done for other join table/BelongsToMany conversions.
5 tasks
hanzlamateen
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the current state where not everything has been converted off of sequelize, some sequelize BelongsToMany (join table) associations are bugging because they are being made under new names without all of the required fields before the knex migration can create it properly.
Specifically, instance_authorized_user was renamed to instance-authorized-user. The sequelize BelongsToMany relationship between user and instance is making a new instance-authorized-user table just based on that relationship, which doesn't know about the 'id' field. Then the knex migration tries to run, and fails because the instance-authorized-user table already exists. The deployment then has bugs because the table schema isn't correct.
The solution was to make the migration delete the new table if it exists if it detects that the old table still exists. This probably needs to be done for other join table/BelongsToMany conversions.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.