This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Updated project update process to run as job in K8s. #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
force-pushed
the
project-update-jobs
branch
4 times, most recently
from
5d88bd6
to
4070ad1
Compare
hanzlamateen
suggested changes
Aug 11, 2023
barankyle
force-pushed
the
project-update-jobs
branch
2 times, most recently
from
8479c8f
to
4c3acf8
Compare
hanzlamateen
approved these changes
Aug 14, 2023
|
|
||
| const userId = params!.user?.id || project.updateUserId | ||
|
|
||
| const githubIdentityProviderResult = (await app.service('identity-provider').find({ |
There was a problem hiding this comment.
Since, there is an identity-provider PR up for review as well. So just to avoid missing this one out. You can use identityProviderPath here instead of string.
barankyle
force-pushed
the
project-update-jobs
branch
from
4c3acf8
to
4562953
Compare
hanzlamateen
suggested changes
Aug 18, 2023
barankyle
force-pushed
the
project-update-jobs
branch
2 times, most recently
from
4b4c247
to
4651b48
Compare
hanzlamateen
approved these changes
Aug 22, 2023
barankyle
force-pushed
the
project-update-jobs
branch
2 times, most recently
from
5b1095c
to
32fa8b8
Compare
Updates of large projects could cause API servers to freeze for a noticeable amount of time. Changed the process to start a job to run that update when in a Kubernetes environment, and to wait for that job to finish before returning.
barankyle
force-pushed
the
project-update-jobs
branch
from
32fa8b8
to
b97351a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #8428
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.