This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixing some $like searches on projects #8695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions that were searching on project names via $like: %<name>% were returning hits that it shouldn't have gotten, e.g. finds on `project-name` getting hits on projects `project-name` and `project-name-avatars`. If the bad hits happened to come first in the array because their ID happened to come first, this would result in unwanted behavior like patching the wrong project. Removed the %'s in these queries, which match additional characters. We only use $like for case-insensitivity purposes.
HexaField
approved these changes
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some functions that were searching on project names via $like: %% were returning hits that it shouldn't have gotten, e.g. finds on
project-namegetting hits on projectsproject-nameandproject-name-avatars. If the bad hits happened to come first in the array because their ID happened to come first, this would result in unwanted behavior like patching the wrong project.Removed the %'s in these queries, which match additional characters. We only use $like for case-insensitivity purposes.
References
closes #8694
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.