Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for login service to use schema, knex & feathers 5 #8723

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Changes for login service to use schema, knex & feathers 5 #8723

merged 6 commits into from
Sep 14, 2023

Conversation

hurairahmateen
Copy link
Member

@hurairahmateen hurairahmateen commented Sep 11, 2023 •
edited by barankyle
Loading

Summary

A summary of changes being made in this PR

References

#7645, closes #8701

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@hurairahmateen hurairahmateen marked this pull request as ready for review September 11, 2023 03:09
@barankyle barankyle added this pull request to the merge queue Sep 14, 2023
Merged via the queue into dev with commit 37b8f8c Sep 14, 2023
8 checks passed
@barankyle barankyle deleted the login-feathers5 branch September 14, 2023 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barankyle barankyle barankyle approved these changes

@speigg speigg Awaiting requested review from speigg

@hanzlamateen hanzlamateen Awaiting requested review from hanzlamateen hanzlamateen is a code owner

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate login service to feathers 5
2 participants
@hurairahmateen @barankyle