Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Optimize, Fix, and improve #8772

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Optimize, Fix, and improve #8772

merged 3 commits into from
Sep 14, 2023

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Sep 13, 2023 •
edited
Loading

Summary

  • Added load event on window for e2e testing
  • Fixed Drop Shadow raycasting
  • Disabling shadows now disables shadowmap in threejs saving a couple draw calls
  • Optimized system execute saving a couple ms

References

#8771

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

@DanielBelmes
ShadowSystem fully disabled, Drop Shadow Tracking Fixed, Add Mobile t…
d6f5fad 
…o IsMobile, add load event, small engine optimization
@DanielBelmes DanielBelmes linked an issue Sep 13, 2023 that may be closed by this pull request
[Bug]: Optimizations for Engine and nice features #8771
Closed
HexaField
HexaField suggested changes Sep 14, 2023
View reviewed changes
packages/engine/src/scene/systems/ShadowSystem.tsx Outdated Show resolved Hide resolved
packages/engine/src/scene/systems/ShadowSystem.tsx Outdated Show resolved Hide resolved
packages/engine/src/xr/XRState.ts Outdated Show resolved Hide resolved
@HexaField HexaField merged commit e99164b into dev Sep 14, 2023
8 checks passed
@HexaField HexaField deleted the 8771-bug-optimizations-for-engine-and-nice-features branch September 14, 2023 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HexaField HexaField HexaField approved these changes

@speigg speigg Awaiting requested review from speigg speigg is a code owner

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Optimizations for Engine and nice features
2 participants
@DanielBelmes @HexaField