This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Avatar Loading Fail Fallback #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
approved these changes
Sep 20, 2023
speigg
approved these changes
Sep 20, 2023
| .service(userPath) | ||
| .patch(Engine.instance.userID, { avatarId: avatarId }) | ||
| .then(() => { | ||
| dispatchAction( |
There was a problem hiding this comment.
I dont believe we really need both of these mechanisms. Can we just standardize on listenting for avatar id changes via the feather hooks?
There was a problem hiding this comment.
this action is what drives our event sourcing, thus it must be persisted to our cached actions
| Engine.instance.api | ||
| .service(avatarPath) | ||
| .get(state.avatarID.value) | ||
| .then((avatarDetails) => { | ||
| if (aborted) return |
There was a problem hiding this comment.
We should be passing down a AbortSignal all the way to the fetch() request, so that network requests can be cancelled when they are no longer necessary
There was a problem hiding this comment.
yes, can do in a follow up when we have better tooling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework avatar loading to be safer by adding fallback to randomized avatars
Summary
🤖 Generated by Copilot at 57fb289
No summary available (Limit exceeded: required to process 53613 tokens, but only 50000 are allowed per call)
References
closes #8835
Explanation
🤖 Generated by Copilot at 57fb289
No walkthrough available (Limit exceeded: required to process 53613 tokens, but only 50000 are allowed per call)
🤖 Generated by Copilot at 273fe51
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist