Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix(admin): instance id being sent in location #8843

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Sep 19, 2023

Summary

🤖 Generated by Copilot at 12f7cdb

This pull request improves the code quality and functionality of the invite management components in client-core. It refactors the CreateInviteModal.tsx component and fixes a bug in the AdminInvites.tsx component.

References

closes #8731

Explanation

🤖 Generated by Copilot at 12f7cdb

  • Fix bug in invite deletion confirmation dialog by using inviteId.value instead of inviteId.set (link)
  • Simplify syntax for creating input menu items in create invite modal by using parentheses and implicit return for map callbacks (link)
  • Refactor logic for assigning target object id for invite based on invite type by using a variable and conditional assignment instead of ternary operators (link)

🤖 Generated by Copilot at 12f7cdb

No more bugs in the dialog of doom
We fixed the inviteId with a value, not a function
Simplifying the code in the modal of creation
We use implicit return and conditional assignment for the invitation

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@aditya-mitra aditya-mitra marked this pull request as draft September 19, 2023 12:02
@aditya-mitra aditya-mitra marked this pull request as ready for review September 22, 2023 13:01
@HexaField HexaField merged commit 8c0d37d into dev Sep 25, 2023
13 checks passed
@HexaField HexaField deleted the fix/admin-create-invite branch September 25, 2023 05:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Location and instance invite creation using wrong ID
3 participants