This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
rewrite reactive UVOL #8848
Merged
rewrite reactive UVOL #8848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/engine/src/scene/components/UVOLComponents/UVOL1/CortoWorker.ts
Fixed
Show fixed
Hide fixed
packages/engine/src/scene/components/UVOLComponents/UVOL1/CortoWorker.bundle.js
Fixed
Show fixed
Hide fixed
CITIZENDOT
force-pushed
the
uvol-rewrite
branch
from
01efa7a
to
98e14a6
Compare
CITIZENDOT
force-pushed
the
uvol-rewrite
branch
from
0e34a9f
to
99dc2de
Compare
CITIZENDOT
force-pushed
the
uvol-rewrite
branch
from
99dc2de
to
615af1f
Compare
`meshopt_decoder.module.js` stringifies some functions and spawns workers. Production build optimizes these files and changes the function names, which causes issues. It's better if we just hand over the function source, instead of stringifying.
speigg
suggested changes
Oct 1, 2023
UVOL1.Loading.effect.mp4UVOL1 Loading effect |
CITIZENDOT
force-pushed
the
uvol-rewrite
branch
from
8807514
to
e25c4e4
Compare
HexaField
previously requested changes
Oct 16, 2023
attributes should not be disposed when setting keyframeB. Because it'll be used by keyframeA in the next frame.
- Stricter heuristic for autotuning targets - Upload the textures (with initTexture) to GPU as soon as they're decoded. - Doing this at render time will cause some lag
speigg
approved these changes
Oct 23, 2023
…ne into uvol-rewrite
Also fixed the pause being overwritten by snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
closes #8524, #8517
Explanation
🤖 Generated by Copilot at 8accee5
CortoWorker.tsfile that contains the web worker code for fetching and decoding UVOL1 frames (link)UVOL1Component.tsfile that contains the component code for handling UVOL1 playback logic (link)interfaces.tsfile that contains the type definitions and enums for the UVOL1 component and worker (link)VolumetricComponent.tsfile to import and useUVOL1Componentfor UVOL1 playback (link, link, link)PositionalAudioComponent.tsandMediaSystem.tsfiles (link, link, link, link, link, link)hasComponent,setComponent,MediaComponent, andVolumetricComponentfromPositionalAudioComponent.tsandMediaSystem.tsfiles (link, link, link)MediaComponentto the entity inPositionalAudioComponentonInit function (link)volumetricQueryresults inMediaSystem.tsfile (link, link)useLoadingEffectproperty and logic fromVolumetricComponent.tsfile (link, link)useLoadingEffectproperty fromVolumetricComponentas it is not relevant for UVOL1 playback (link)useLoadingEffectproperty inVolumetricComponentonSet function (link)🤖 Generated by Copilot at 8accee5
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist