This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
refactor(routerservice): remove arbitary service #8858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 4882305
This pull request replaces the
RouterService
class with a reactiveRouterState
object for routing logic in the client core and editor packages. This makes the code simpler, more consistent, and more reactive. It updates the imports and calls toRouterState
in various components and pages.References
implements #8305
Explanation
🤖 Generated by Copilot at 4882305
navigate
method to theRouterState
object to update thepathname
state and trigger a navigation to a given URL (link)RouterService
class, which is no longer needed after the refactoring to useRouterState
(link)EngineHooks.tsx
, which contains custom hooks for the engine logic (link, link)LoadLocationScene.tsx
, which contains the component for loading a location scene (link, link)RoomMenu.tsx
, which contains the component for the room menu in the user menu (link, link, link)editor.tsx
, which contains the component for the editor page (link, link)EditorContainer.tsx
, which contains the component for the editor container (link, link, link)ScenesPanel.tsx
, which contains the component for the scenes panel in the assets panel (link, link, link)ProjectsPage.tsx
, which contains the component for the projects page (link, link)🤖 Generated by Copilot at 4882305
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist