This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
8777 Cleanup hookstate usage around components #8863
Merged
HexaField
merged 9 commits into
dev
from
8777-bug-not-using-hookstate-destroy-on-statemap-clear
Sep 29, 2023
Merged
8777 Cleanup hookstate usage around components #8863
HexaField
merged 9 commits into
dev
from
8777-bug-not-using-hookstate-destroy-on-statemap-clear
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future when we update hookstate this will be changed to destroy(State) instead
DanielBelmes
changed the title
8777 bug not using hookstate destroy on statemap clear
8777 Cleanup hookstate usage around components
Sep 20, 2023
speigg
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing, please run npm run check-errors
HexaField
approved these changes
Sep 25, 2023
HexaField
suggested changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we spoke, and the test can be improved
HexaField
approved these changes
Sep 25, 2023
HexaField
deleted the
8777-bug-not-using-hookstate-destroy-on-statemap-clear
branch
September 29, 2023 22:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed removeComponent set to none as per hookstates api.
Removed EntityRemovedComponent system
Removed subscribable from existanceMapState
References
#8777
Explanation
🤖 Generated by Copilot at 347d53f
bitECS.removeEntity
andgetAllEntities
instead of a customEntityRemovedComponent
and query (link, link, link, link, link, link, link, link, link, link, link, link)Subscribable
generic parameter andsubscribable()
argument fromexistenceMapState
property inComponent
interface anddefineComponent
function, as they are not needed (link, link, link)none
instead ofundefined
to set the component state when removing a component, and add some commented out code for future implementation of destroying and deleting the state map entry (link)hookstate
is needed for thestateMap
entry even if the component is undefined inuseOptionalComponent
function (link)Checklist