Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix ios audio #8867

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix ios audio #8867

merged 1 commit into from
Sep 21, 2023

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Sep 20, 2023

Summary

🤖 Generated by Copilot at 99d13b6

Fix autoplay bug and refactor code for media components. The change ensures that media elements play automatically when required and avoids unnecessary calls to getComponent in MediaComponent.ts.

References

#8866

Explanation

🤖 Generated by Copilot at 99d13b6

  • Fix media autoplay bug and refactor code (link)

🤖 Generated by Copilot at 99d13b6

media resumes
when autoplay is enabled
a bug fix for fall

QA Steps

Open on IOS and hear sounds of apartment city

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@DanielBelmes DanielBelmes linked an issue Sep 20, 2023 that may be closed by this pull request
@speigg speigg added this pull request to the merge queue Sep 21, 2023
Merged via the queue into dev with commit 74f3953 Sep 21, 2023
12 of 13 checks passed
@speigg speigg deleted the 8866-bug-audio-on-ios-no-longer-autoplaying branch September 21, 2023 02:00
barankyle pushed a commit that referenced this pull request Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Audio on IOS no longer autoplaying
2 participants