This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
introduced a state concept for asset loader and migrated gltfloader t… #8869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced a state concept for asset loader and migrated gltfloader to it
Summary
🤖 Generated by Copilot at 3f734e2
This pull request refactors the gltfLoader management in the engine package to use a state object instead of a class property. This reduces the module dependencies, simplifies the code, and improves the testability. The changes affect the
AssetLoader
,Engine
,SceneObjectSystem
,AssetLoaderState
, andavatarFunctions.test
modules.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 3f734e2
Engine
class inEngine.ts
(link, link)AssetLoaderState.ts
that defines theAssetLoaderState
object that holds the gltfLoader instance (link)AssetLoaderState
module inAssetLoader.ts
andSceneObjectSystem.tsx
(link, link)AssetLoader.ts
that use the gltfLoader to access it from theAssetLoaderState
object (link, link, link)SceneObjectSystem.tsx
that uses the gltfLoader to access it from theAssetLoaderState
object (link)avatarFunctions.test.ts
that uses the gltfLoader to access it from theAssetLoaderState
object (link)🤖 Generated by Copilot at 3f734e2
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist