Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix thumbnails #8878

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix thumbnails #8878

merged 2 commits into from
Sep 25, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Sep 22, 2023

Summary

🤖 Generated by Copilot at f74c7f4

Improved the MaterialEditor component by optimizing the memoization and effect hooks. This reduces unnecessary re-rendering and ensures the thumbnails reflect the material parameters.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at f74c7f4

  • Removed unnecessary dependency from useMemo hook to avoid re-rendering MaterialEditor component (link)
  • Added missing dependency to useEffect hook to update thumbnails of material parameters (link)

🤖 Generated by Copilot at f74c7f4

MaterialEditor
Faster, smoother with new hooks
Autumn leaves fall down

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@dinomut1 dinomut1 added this pull request to the merge queue Sep 25, 2023
Merged via the queue into dev with commit 1130085 Sep 25, 2023
13 checks passed
@dinomut1 dinomut1 deleted the material-panel-thumbnail-fix branch September 25, 2023 19:40
barankyle pushed a commit that referenced this pull request Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants