This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Changes to use hooks and resolvers instead of custom class for channel service #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 0513acb
This pull request enhances the channel service with new hooks to check user permissions and relationships before allowing channel operations. It also improves the error handling and code readability of the existing hooks by using feathersjs error classes and the new hooks. The changes affect the file
packages/server-core/src/social/channel/channel.hooks.ts
.References
#8871
Explanation
🤖 Generated by Copilot at 0513acb
BadRequest
andForbidden
error classes fromfeathersjs/errors
(link)ensureUserHasChannelAccess
hook to verify that the user is either the channel owner or a channel member (link)ensureUsersFriendWithOwner
hook to verify that the user is a friend of the channel owner or the owner themselves (link)channel
module and document hooks with comments (link)get
andcreate
methods ofchannel
service with the new hooks (link)🤖 Generated by Copilot at 0513acb
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist