This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 5cecdc0
This pull request refactors and improves the bounding box component, the scene serialization function, and the transform system. It enhances the consistency, flexibility, modularity, and efficiency of the engine's core features. It affects the files
BoundingBoxComponent.ts
,serializeWorld.ts
, andTransformSystem.ts
.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 5cecdc0
BoundingBoxComponent
to use an entity-based helper instead of aBox3Helper
object (link, link, link)computeBoundingBox
function fromTransformSystem
toBoundingBoxComponents
(link, link)SceneObjectComponent
in theserializeWorld
function (link, link, link)computeBoundingBox
for static entities in theexecute
function of theTransformSystem
(link)🤖 Generated by Copilot at 5cecdc0
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist