Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix Dynamic Bounding Boxes #8916

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Fix Dynamic Bounding Boxes #8916

merged 3 commits into from
Sep 28, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Sep 27, 2023

Summary

🤖 Generated by Copilot at 5cecdc0

This pull request refactors and improves the bounding box component, the scene serialization function, and the transform system. It enhances the consistency, flexibility, modularity, and efficiency of the engine's core features. It affects the files BoundingBoxComponent.ts, serializeWorld.ts, and TransformSystem.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 5cecdc0

  • Updated the BoundingBoxComponent to use an entity-based helper instead of a Box3Helper object (link, link, link)
  • Moved the computeBoundingBox function from TransformSystem to BoundingBoxComponents (link, link)
  • Skipped entities that do not have a SceneObjectComponent in the serializeWorld function (link, link, link)
  • Removed the call to computeBoundingBox for static entities in the execute function of the TransformSystem (link)

🤖 Generated by Copilot at 5cecdc0

We're refactoring the code, me hearties, yo ho ho
We're using BoundingBoxComponent to make it glow
We're serializing the scene, me lads and lasses, heave away
We're pulling on the TransformSystem on the count of three

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField changed the title start improving bounding box Fix Dynamic Bounding Boxes Sep 28, 2023
@HexaField HexaField marked this pull request as ready for review September 28, 2023 01:51
@HexaField HexaField merged commit 7d4c47a into dev Sep 28, 2023
12 of 13 checks passed
@HexaField HexaField deleted the bounding-box-improvements branch September 28, 2023 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants