Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix AR Placement #8935

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Fix AR Placement #8935

merged 6 commits into from
Oct 2, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Sep 29, 2023

Summary

🤖 Generated by Copilot at 73a1db0

This pull request improves the performance, consistency, and user experience of the engine's XR mode. It fixes bugs and optimizes the code in ClientInputSystem.ts, TransformComponent.ts, XRAnchorSystem.ts, XRCameraSystem.ts, and XRState.ts. It also removes a line that was overriding the user's camera mode preference in AvatarAnimationSystem.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 73a1db0

  • Fixed bugs and improved performance of the XR camera system by using a constant vector for the scale component of the camera transforms (link, link, link) in XRCameraSystem.ts.

🤖 Generated by Copilot at 73a1db0

Sing, O Muse, of the valiant pull request
That fixed and optimized the XR mode
And made the scene and camera more adept
To render the immersive virtual abode.

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField marked this pull request as ready for review September 29, 2023 12:59
@HexaField HexaField merged commit 945e2d2 into dev Oct 2, 2023
13 checks passed
@HexaField HexaField deleted the ar-placement-fixes branch October 2, 2023 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant