This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Added some checks for resolvers after removes #8936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avatar removal was returning errors. This was caused by the avatarResolver fetching model and thumbnail static-resources, but on avatar deletion, these have been removed, which makes the .get's error. Made this not trigger when context.event is 'removed', and applied this to other resolvers that fetch static-resources.
Cleaned up some redundant function calls that are assigned to variables before just returning the variable.
🤖 Generated by Copilot at 94fcdac
This pull request refactors and optimizes various virtual fields in the resolvers of different entities in
packages/server-core/src
. It removes unnecessary conditions, variables, and return statements, and avoids database queries for deleted entities. The purpose is to improve the performance, readability, and error handling of the resolvers.References
closes #8930
Explanation
🤖 Generated by Copilot at 94fcdac
🤖 Generated by Copilot at 94fcdac
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist