This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Changes for route, login-token services hook refactor #8992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at fa04c16
Refactored the
RouteService
andLoginTokenService
classes to useKnexService
and custom hooks. Added pagination support for theRouteService
to allow clients to fetch routes more efficiently. Simplified and cleaned up some code and imports.References
#8871
Explanation
🤖 Generated by Copilot at fa04c16
RouteService
andLoginTokenService
classes to extendKnexService
instead ofKnexAdapter
for more flexibility and simplicity (link, link, link, link, link, link)enableClientPagination
hook toRouteService
andLoginTokenService
to allow clients to request pagination options for thefind
method using query parameters (link, link, link)LoginTokenService
class to a separategenerateToken
hook function (link, link, link, link)Login
class to use theremove
method instead of the_remove
method of theLoginTokenService
, and to cast the result of thefind
method asPaginated<LoginTokenType>
(link, link, link)🤖 Generated by Copilot at fa04c16
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist