This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at a166595
Improved the performance and code quality of spline editing components in the editor package. Used
NO_PROXY
to avoid unnecessary reactivity forSplineComponent.elements
, and ensured proper type conversion forposition
andquaternion
properties. Removed unused and redundant code fromSplineTrackNodeEditor.tsx
.References
closes #insert number here
Explanation
🤖 Generated by Copilot at a166595
NO_PROXY
symbol to access raw values of reactive properties without triggering reactivity (link)get
method withNO_PROXY
argument to avoid reactive dependency onelements
array ofSplineComponent
(link, link)Vector3
andQuaternion
instances before updatingposition
andquaternion
properties ofSplineComponent
(link, link)onChange
andonRelease
functions fromSplineTrackNodeEditor
component (link, link)onChange
andonRelease
handlers withcommitProperty
function to updatevelocity
property ofSplineTrackComponent
(link)🤖 Generated by Copilot at a166595
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist