This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 59ba572
This pull request simplifies and optimizes the loading UI and user avatar logic by using a new
userReady
property in theEngineState
. It removes unused code and imports from several files, and updates theLoadingUISystem.tsx
andCameraSystem.tsx
files to use theuserReady
property to handle loading transitions.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 59ba572
userReady
property toEngineState
to track user avatar and camera loading (link)metadataLoaded
property fromLoadingUISystemState
and replaced it withuserReady
andsceneLoaded
fromEngineState
(link, link)userReady
totrue
inloadAvatarForUser
function if entity islocalClientEntity
(link)userReady
totrue
inCameraSystem
after camera initialization (link)EngineActions
,defineActionQueue
, anddispatchAction
from various files (link, link, link)avatarModelChangedQueue
,spectateUserQueue
, andavatarModelChanged
action from various files (link, link, link)LoadingUISystem.tsx
(link)🤖 Generated by Copilot at 59ba572
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist