Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for user drawer #9118

Merged
merged 12 commits into from
Oct 26, 2023
Merged

Changes for user drawer #9118

merged 12 commits into from
Oct 26, 2023

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 22, 2023

Summary

🤖 Generated by Copilot at 9206437

This pull request improves the user management and scope type features of the admin interface. It refactors the UserDrawer component to make it more reusable and customizable, and adds pagination and conditional logic to the scope-type service.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 9206437

  • Split UserDrawer component into two components: LinkedAccounts and UserDrawer in UserDrawer.tsx (link)
  • Wrap UserDrawer component with createHookableFunction to make it extensible by other plugins or extensions in UserDrawer.tsx (link, link)
  • Modify query for fetching scope types from the server to fetch all scope types at once in UserDrawer.tsx and scope-type.hooks.ts (link, link)
  • Add enableClientPagination hook to scope-type service to allow client-side pagination for external requests in scope-type.hooks.ts (link, link, link)
  • Export UserDrawerProps and defaultState from UserDrawer.tsx to make them available for other modules (link, link)
  • Import createHookableFunction from common package in UserDrawer.tsx (link)
  • Remove unused variables and code related to identity providers and scope types pagination in UserDrawer.tsx (link, link, link)

🤖 Generated by Copilot at 9206437

Sing, O Muse, of the skillful refactorer
Who split the UserDrawer in twain
And made it hookable for other plugins
With createHookableFunction's aid.

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@hanzlamateen hanzlamateen marked this pull request as ready for review October 24, 2023 11:20
@hanzlamateen
Copy link
Member Author

Merging this PR for now, as I need to deploy these changes. If any concerns, they can be addressed in a separate PR.

@hanzlamateen hanzlamateen merged commit 3d7924a into dev Oct 26, 2023
10 of 12 checks passed
@hanzlamateen hanzlamateen deleted the user-drawer-changes branch October 26, 2023 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant