Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixed issue with first user not being made admin #9120

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 23, 2023

Summary

🤖 Generated by Copilot at b137218

Improved documentation and development mode support for identity providers in server-core. Added a comment to explain the guest-only logic and changed the admin type assignment to work with any identity provider type.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at b137218

  • Prevent unauthorized account creation with non-password/magiclink identity providers by requiring guest type for those requests (link)
  • Allow developers to create admin accounts with any identity provider type in development mode by checking both mode and type conditions (link)

🤖 Generated by Copilot at b137218

guest-only rule
clarified for identities
admin type varies

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@hanzlamateen hanzlamateen merged commit 648da06 into dev Oct 23, 2023
9 checks passed
@hanzlamateen hanzlamateen deleted the make-first-user-admin branch October 23, 2023 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant