Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix dragging component from panel #9129

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix dragging component from panel #9129

merged 1 commit into from
Oct 24, 2023

Conversation

CITIZENDOT
Copy link
Collaborator

@CITIZENDOT CITIZENDOT commented Oct 24, 2023

Summary

🤖 Generated by Copilot at a2beca1

Fixed a bug in ElementList component that caused incorrect rendering and selection of components with missing or duplicate names. Changed the componentJsonID property to use item.jsonID instead of item.name in packages/editor/src/components/element/ElementList.tsx.

References

closes #9122

Explanation

🤖 Generated by Copilot at a2beca1

  • Use jsonID instead of name as the component identifier in ElementList (link)

🤖 Generated by Copilot at a2beca1

componentJsonID
now uses item.jsonID
name is not enough

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@CITIZENDOT CITIZENDOT added this pull request to the merge queue Oct 24, 2023
Merged via the queue into dev with commit 0536e57 Oct 24, 2023
12 of 14 checks passed
@CITIZENDOT CITIZENDOT deleted the 9122-fix-drag-n-drop branch October 24, 2023 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dragging and Dropping Components into Scene Creates Blank Nodes
2 participants