Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

add default arguement to add media node func #9150

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Oct 26, 2023

Summary

🤖 Generated by Copilot at 8d85715

Updated addMediaNode function to use scene state and default parent. This improves the usability and consistency of the function when adding media nodes to the scene.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 8d85715

  • Import SceneState and getState modules to access scene entity and state (link)
  • Change default value of parent parameter in addMediaNode function to be scene entity (link)

🤖 Generated by Copilot at 8d85715

No more orphans in the scene, we give them a home
We import the modules that let us access the dome
We set the default parent with the state of the art
We simplify the function, we make it smart

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@SYBIOTE SYBIOTE changed the title add defautl arguement to add media node func add default arguement to add media node func Oct 27, 2023
@HexaField HexaField merged commit 689c87e into dev Oct 28, 2023
8 checks passed
@HexaField HexaField deleted the media-node-default branch October 28, 2023 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants