Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Scene Reactor Loading Refactor #9151

Merged
merged 23 commits into from
Oct 30, 2023
Merged

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Oct 27, 2023

Summary

🤖 Generated by Copilot at 059b160

Refactored the scene loading system to support multiple scenes and dynamic loading using React components. Moved scene and entity creation logic to Scene.ts file and added state management for loading entities. Removed unused or redundant files and functions related to the old scene loading system. Updated the test file for EntityTree.ts to reflect the changes.

References

closes #8673

Explanation

🤖 Generated by Copilot at 059b160

  • Refactor scene loading system to support multiple scenes and use React components for loading entities (link, link, link, link, link, link, link, link, link)
  • Implement dynamic loading feature for scene objects based on distance to avatar (link, link, link, link, link, link)
  • Remove unused imports and functions from EntityTree.ts and EntityTree.test.ts files (link, link, link, link)
  • Delete ChildrenComponent.ts and ParentComponent.ts files as they are no longer needed (link, link)

🤖 Generated by Copilot at 059b160

Sing, O Muse, of the mighty refactor of the scene loading system
That the skilled coder wrought with his swift fingers and keen mind
He removed the initializeSceneEntity function, that ancient relic
And replaced it with a new schema and state, more flexible and dynamic

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField marked this pull request as ready for review October 29, 2023 11:00
@HexaField HexaField marked this pull request as draft October 29, 2023 11:01
@HexaField HexaField marked this pull request as ready for review October 30, 2023 00:04
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scaling colliders in studio is broken in this branch
To reproduce: Opening an empty scene, placing box collider and trying to scale it. Right now it's not updating in real time, and it does update in real time on dev

@HexaField HexaField merged commit 0ec8240 into dev Oct 30, 2023
13 checks passed
@HexaField HexaField deleted the multi-scene-loading-state-refactor branch October 30, 2023 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SceneLoadingSystem to Track State of Multiple Scenes
2 participants