This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinomut1
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scaling colliders in studio is broken in this branch
To reproduce: Opening an empty scene, placing box collider and trying to scale it. Right now it's not updating in real time, and it does update in real time on dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 059b160
Refactored the scene loading system to support multiple scenes and dynamic loading using React components. Moved scene and entity creation logic to
Scene.ts
file and added state management for loading entities. Removed unused or redundant files and functions related to the old scene loading system. Updated the test file forEntityTree.ts
to reflect the changes.References
closes #8673
Explanation
🤖 Generated by Copilot at 059b160
EntityTree.ts
andEntityTree.test.ts
files (link, link, link, link)ChildrenComponent.ts
andParentComponent.ts
files as they are no longer needed (link, link)🤖 Generated by Copilot at 059b160
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist