Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes to replace type with interface in schemas to allow declaration #9165

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Oct 30, 2023

Summary

Made these changes to allow redeclaring an existing schemas.
Reference: https://discord.com/channels/509848480760725514/1165964336641093642/1167704370071212032

🤖 Generated by Copilot at 1654034

This pull request disables the @typescript-eslint/no-empty-interface rule in the ESLint configuration file and removes the unnecessary comments that disable the rule in various TypeScript files. It also changes one type alias to an interface and formats one JSON file for consistency. These changes improve the code quality and style of the TypeScript codebase.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 1654034

  • Disable the @typescript-eslint/no-empty-interface rule in the ESLint configuration file .eslintrc.cjs (link)
  • Remove the comments that disable the same rule for various classes in the packages/server-core/src directory (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Remove the comment that disable the same rule for the DeepReadonly type in the packages/common/src/DeepReadonly.ts file (link)
  • Change the AnalyticsType type to an interface in the packages/engine/src/schemas/analytics/analytics.schema.ts file (link)
  • Format the types array in the packages/engine/tsconfig.json file to use one line per item (link)

🤖 Generated by Copilot at 1654034

no-empty-interface
Disabled for all the files
Spring cleaning the code

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@hanzlamateen hanzlamateen changed the title Changes to replace type to interface in schemas to allow declaration Changes to replace type with interface in schemas to allow declaration Oct 30, 2023
@hanzlamateen hanzlamateen marked this pull request as ready for review October 30, 2023 02:53
@hanzlamateen hanzlamateen added this pull request to the merge queue Oct 31, 2023
Merged via the queue into dev with commit 95cea61 Oct 31, 2023
13 checks passed
@hanzlamateen hanzlamateen deleted the schema-refactor-interface branch October 31, 2023 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants