This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Changes to replace type with interface in schemas to allow declaration #9165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made these changes to allow redeclaring an existing schemas.
Reference: https://discord.com/channels/509848480760725514/1165964336641093642/1167704370071212032
🤖 Generated by Copilot at 1654034
This pull request disables the
@typescript-eslint/no-empty-interface
rule in the ESLint configuration file and removes the unnecessary comments that disable the rule in various TypeScript files. It also changes one type alias to an interface and formats one JSON file for consistency. These changes improve the code quality and style of the TypeScript codebase.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 1654034
@typescript-eslint/no-empty-interface
rule in the ESLint configuration file.eslintrc.cjs
(link)packages/server-core/src
directory (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)DeepReadonly
type in thepackages/common/src/DeepReadonly.ts
file (link)AnalyticsType
type to an interface in thepackages/engine/src/schemas/analytics/analytics.schema.ts
file (link)types
array in thepackages/engine/tsconfig.json
file to use one line per item (link)🤖 Generated by Copilot at 1654034
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist