Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

do not pass user using async storage in test mode #9166

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 30, 2023

Summary

🤖 Generated by Copilot at fb6eee5

This pull request fixes a bug and enhances the security and testing of the invite service. It passes the test user to the service methods, checks the test mode before skipping authentication, and removes an outdated comment from invite.test.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at fb6eee5

  • Prevent unauthorized access to invite service in production mode by checking test mode before skipping authentication (link)
  • Fix bug that caused invite to have null senderId by passing test user as parameter to create method of invite service (link)
  • Improve test coverage and functionality of invite service by uncommenting and updating test cases in invite.test.ts (link, link)

🤖 Generated by Copilot at fb6eee5

test mode checked first
avoid unauthorized calls
autumn bug is fixed

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@aditya-mitra aditya-mitra changed the title do not pass user using async storage with test mode do not pass user using async storage in test mode Oct 30, 2023
@aditya-mitra aditya-mitra added this pull request to the merge queue Oct 30, 2023
Merged via the queue into dev with commit a502c48 Oct 30, 2023
14 checks passed
@aditya-mitra aditya-mitra deleted the tests/async-storage branch October 30, 2023 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants