Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixes-for-console-errors #9172

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fixes-for-console-errors #9172

merged 3 commits into from
Nov 3, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Oct 30, 2023

Summary

🤖 Generated by Copilot at cfb03f4

Modified NumericInput and StyledNumericInput components to support ref props and unit display. This improves the keyboard navigation and input validation of the numeric inputs in the editor.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at cfb03f4

  • Forward ref prop to input element and add unit prop to StyledNumericInput component (link)
  • Forward ref prop to StyledNumericInput component and remove unit prop from NumericInput component (link)

🤖 Generated by Copilot at cfb03f4

ref prop added
to StyledNumericInput
winter keyboard fun

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@speigg
Copy link
Member

speigg commented Nov 2, 2023

@SYBIOTE conflicts need to be resolved

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Nov 2, 2023

This might not be needed anymore, ill check on this nonetheless

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Nov 2, 2023

Fixed

@HexaField HexaField merged commit 545bf5e into dev Nov 3, 2023
13 checks passed
@HexaField HexaField deleted the fixes-for-console-errors branch November 3, 2023 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants