Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

refactor scopes for client-setting service #9183

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 31, 2023

Summary

🤖 Generated by Copilot at 86e8f97

This pull request introduces new scope types for the client settings service, which handles the web app manifest and other client-side settings. The new scope types settings_client:read and settings_client:write are added to the file scope-type.seed.ts and used in the file client-setting.hooks.ts to replace the previous scope verification.

References

refs #9161

Explanation

🤖 Generated by Copilot at 86e8f97

  • Add new scope types for client settings (link)
  • Update scope verification for client settings service (link)

🤖 Generated by Copilot at 86e8f97

New scope types added
settings_client controls
Web app in autumn

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@barankyle barankyle added this pull request to the merge queue Nov 1, 2023
Merged via the queue into dev with commit aa3c51c Nov 1, 2023
14 checks passed
@barankyle barankyle deleted the refactor/client-setting-scoping branch November 1, 2023 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants