Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

do not show empty brackets when no asset resource is selected #9186

Merged
merged 2 commits into from
Oct 31, 2023
Merged

do not show empty brackets when no asset resource is selected #9186

merged 2 commits into from
Oct 31, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Oct 31, 2023 •
edited by ghost
Loading

Summary

🤖 Generated by Copilot at d5f6ec0

Added debugging and error handling to AssetsPreviewPanel.tsx to fix a bug with missing asset previews.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at d5f6ec0

  • Added a console log and a conditional check to fix the preview panel bug (link)
  • Prevented rendering the asset name and size if they are undefined or null (link)

🤖 Generated by Copilot at d5f6ec0

console.log helps
debug preview panel props
avoid null errors

QA Steps

Before

ffd3778ec176094a9e00da4b448ff3a1

406f0eb21163267330d72dfb436411ef

After

image

image

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@barankyle barankyle added this pull request to the merge queue Oct 31, 2023
Merged via the queue into dev with commit 897fde3 Oct 31, 2023
13 checks passed
@barankyle barankyle deleted the fix/assets-preview-brackets branch October 31, 2023 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barankyle barankyle barankyle approved these changes

@HexaField HexaField Awaiting requested review from HexaField

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-mitra @barankyle