This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 1f3d47b
The pull request refactors the peerID management across the engine, the client, and the instance server by using the HyperFlux store as the single source of truth. This improves the peer-to-peer communication, synchronization, and testing of the engine. It also removes unused and redundant code from several files.
References
closes #insert number here
Explanation
🤖 Generated by Copilot at 1f3d47b
uuidv4
andPeerID
imports from several files where they are no longer needed (link,link,link,link,link)engine_tw.tsx
toengine.tsx
to avoid confusion with the original file (link)Engine.instance.peerID
from a string to a getter that returns the peerID from the HyperFlux store inEngine.ts
(link)Engine.instance.peerID
to a random UUID from several files where it is no longer necessary (link,link,link,link,link,link,link)peerID
variable from a string toEngine.instance.store.peerID
in several test files where it is used to match the peerID of the HyperFlux store (link,link,link,link,link,link,link,link,link,link,link,link,link,link)authorityPeerID
property of theNetworkObjectComponent
from a string toEngine.instance.peerID
inGrabbableSystem.test.ts
(link)peerID
variable from a string toanotherPeerID
inNetworkPeerFunctions.test.ts
to avoid confusion with the peerID of the HyperFlux store and the engine instance (link,link,link)getPeerId
function by thepeerID
property of the HyperFlux store inActionFunctions.ts
(link)uuidv4
andPeerID
imports toStoreFunctions.ts
where they are needed to generate and store the peerID in the HyperFlux store (link)getPeerId
function from theHyperStore
interface and replaced it by thepeerID
property of typePeerID
inStoreFunctions.ts
(link)peerID
property to a random UUID in thecreateHyperStore
function inStoreFunctions.ts
(link)🤖 Generated by Copilot at 1f3d47b
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist