Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

remove unwanted 0 in the debug panel #9208

Merged
merged 1 commit into from
Nov 3, 2023
Merged

remove unwanted 0 in the debug panel #9208

merged 1 commit into from
Nov 3, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Nov 3, 2023

Summary

🤖 Generated by Copilot at cb95119

Fixed circular dependency and cleaned up code in Debug component. This component provides a UI for debugging various aspects of the engine.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at cb95119

  • Simplified the condition for rendering the debug panel by using the !! operator on the localClientEntity value (link)
  • Removed unused import of NetworkState to avoid circular dependency error (link)
  • Deleted unused networks variable from Debug component (link)

🤖 Generated by Copilot at cb95119

The Debug component was a mess
With unused code and excess
The logic was simplified
The circular error defied
Now the code is easier to assess

QA Steps

Earlier

image

Now

image

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Merged via the queue into dev with commit 4e4aa2e Nov 3, 2023
14 checks passed
@barankyle barankyle deleted the fix/debug-panel branch November 3, 2023 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants