Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Remove pending tag if there's no renderer instance #9215

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented Nov 6, 2023

Summary

One liner, title describes all. Remove the scene pending tag if there's no renderer instance. Created to fix capture page hanging on scenes with model components.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 0e9dbd4

  • Fix a bug where some entities would not render properly after loading a scene (link)

🤖 Generated by Copilot at 0e9dbd4

SceneAssetPendingTag
Cut from entity, now free
Scene assets ready

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField merged commit 526fbe9 into dev Nov 6, 2023
14 checks passed
@HexaField HexaField deleted the remove-tag branch November 6, 2023 21:01
HexaField pushed a commit that referenced this pull request Nov 7, 2023
      * Aidan's fix

* LocationID #7094
- Addition to LocationID because of previous miss

* Remove pending tag if there's no renderer instance (#9215)

* Remove pending tag if there's no renderer instance

* remove log.

---------

Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants