This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
loading and error enhancements in studio #9225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show a loading indicator beside the entity whose components are being loaded.
Also fix the error tooltip which was not properly showing the detailed errors.
Note: I replaced
hasComponent(entity, myComponent) set/removeComponent
with justset/removeComponent
as both check for entity before setting/removingReferences
closes part of #9201
QA Steps
3fe46b43-eda4-4db8-80cb-cf551d9dbb24.mp4