This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
ScopeType enforced #9271
Merged
ScopeType enforced #9271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed name of `interface ScopeType` to `interface ScopeTypeInterface`
| @@ -35,7 +37,9 @@ export const scopeTypeMethods = ['find', 'get'] as const | |||
| // Main data model schema | |||
| export const scopeTypeSchema = Type.Object( | |||
| { | |||
| type: Type.String(), | |||
| type: TypedString<ScopeType>({ | |||
| format: 'uuid' | |||
There was a problem hiding this comment.
@HexaField this shouldnt be uuid?
There was a problem hiding this comment.
Oh, perhaps. Does that affect the database?
There was a problem hiding this comment.
It doesn't but maybe at some time in future it will. I have made the fix in #9331
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
interface ScopeTypetointerface ScopeTypeInterfaceScopeTypeopaque type toscope.schema.tsReferences
#7094
Checklist
✔️ Ran npm run check-errors, no related problems
✔️ Ran npm run check, no related problems