-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
doc: Better TextMesh doc comments formatting new: font family editor mapping doc: Reformated all temp TextMesh properties comments for better organization fmt: new "unlikely" temp section for TextMesh properties new: FontDefault value, for initializing the default font URI
new: Font Material property mapped to the editor. new: FontFamily, Clipping, GlyphResolution, GlyphDetail and GPUAccelerated hover info descriptions chg: <br> Separation between each InputGroup section for readability. chg: Default clipRectMin changed to a negative value, so it works as expected by default.
text.glyphDetail | ||
]) | ||
|
||
return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of returning null. Return a function that runs
text.troikaMesh.dispose()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't return null from the reactor body, would have to be inside the useEffect. However, it looks like we're creating the troikaMesh in the component's onInit. Either we move that to the reactor and handle cleanup in a useEffect cleanup, or we should dispose the troika mesh in the onRemove callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its resolved with f2b142a
Let me know if something is missing.
text.glyphDetail | ||
]) | ||
|
||
return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't return null from the reactor body, would have to be inside the useEffect. However, it looks like we're creating the troikaMesh in the component's onInit. Either we move that to the reactor and handle cleanup in a useEffect cleanup, or we should dispose the troika mesh in the onRemove callback.
Summary
Adds support for the Troika text renderer plugin, and (almost all) its configuration options.
Its output is a spatial Component that is exposed in the studio with a TextNodeEditor.
References
n/a
QA Steps
n/a