This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fix projects page search #9436
Merged
Fix projects page search #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speigg
approved these changes
Dec 13, 2023
speigg
suggested changes
Dec 13, 2023
| communityProjects.set(data.sort(sortAlphabetical) ?? []) | ||
| console.log('DEBUG 2', data, communityProjects, filter.value) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the search functionality on the projects page. Previously, the search was not filtering the projects correctly. With this fix, the search will now filter the projects based on the entered query.
the query now filters and shows across both, the installed and community projects section,
do we want to debounce the query to improve performance ?