Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

9402 Batched Compression #9451

Merged
merged 15 commits into from
Dec 26, 2023
Merged

9402 Batched Compression #9451

merged 15 commits into from
Dec 26, 2023

Conversation

Rezmason
Copy link
Contributor

Summary

( Charlie and Jeremy's first big feature!✨ )

  • The model transform properties panel now has a batch compression checkbox; when checked, compressed GLBs with texture size 2048 (LOD_0), 1024 (LOD_1) and 512 (LOD_2) are generated alongside the original file. (The selected model and the original GLTF/GLB are unchanged.)
  • All this functionality is also now available when right-clicking a model in the file browser and choosing "Compress".

References

closes #9402
closes #9418

QA Steps

  1. Load the Studio and open the default project.
  2. In the Scene panel, choose the default scene. Wait for the scene to finish loading.
  3. In the Files panel, navigate into the assets folder, find the file apartment.glb, and drag it into the scene or into the Hierarchy panel. Wait for the model to load and appear.
  4. Select the model.
  5. In the Properties panel, scroll to the Model Transform Properties section and expand it.
  6. Confirm that the Clientside Transform checkbox is now checked by default.
  7. Confirm that there is a new unchecked checkbox, Batch Compress.
  8. Check Batch Compress and click Optimize.
  9. Refresh the Files panel.
  10. Confirm that apartment-transformed-LOD_0.glb, apartment-transformed-LOD_1.glb and apartment-transformed-LOD_2.glb appear in the panel.
  11. In the Files panel, delete apartment-transformed-LOD_0.glb, apartment-transformed-LOD_1.glb and apartment-transformed-LOD_2.glb. Do not delete apartment.glb.
  12. In the Files panel, right-click apartment.glb and click Compress.
  13. Confirm that a popup appears with the name apartment, and that the UI contains an element named Model Format.
  14. Click COMPRESS. Wait for the popup to close.
  15. Confirm that apartment-transformed-LOD_0.glb, apartment-transformed-LOD_1.glb and apartment-transformed-LOD_2.glb appear again in the panel. Delete them if you like.

… is set to batch-compress, it will emit a GLB for each LOD level (0 = 2048, 1 = 1024, 2 = 512) currently hard-coded into the function.
…ilenames assigned to the transform parameters, and onChangeModel shouldn't be called for batch compression for the time being (because there is a many-to-one relationship between the input of the batch compression and the output)
…ormProperties to CompressionPanel, with a temporary filename assigned to all the LODs.
…to the model compression panel. The compression jobs carried out are now represented as slim variants of a de-proxied transform parms.
…rform the same operations on batch and non-batch compressed models
@Rezmason Rezmason force-pushed the 9402-batched-compression-phase-1 branch from a03b325 to c56f9c3 Compare December 26, 2023 19:37
@dinomut1 dinomut1 added this pull request to the merge queue Dec 26, 2023
Merged via the queue into dev with commit 3105347 Dec 26, 2023
8 checks passed
@dinomut1 dinomut1 deleted the 9402-batched-compression-phase-1 branch December 26, 2023 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GLTF Transform into File Browser Batched Compression
2 participants