This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set to batch-compress, it will emit a GLB for each LOD level (0 = 2048, 1 = 1024, 2 = 512) currently hard-coded into the function.
…ilenames assigned to the transform parameters, and onChangeModel shouldn't be called for batch compression for the time being (because there is a many-to-one relationship between the input of the batch compression and the output)
…) when it is opened from a model file.
…ormProperties to CompressionPanel, with a temporary filename assigned to all the LODs.
…to the model compression panel. The compression jobs carried out are now represented as slim variants of a de-proxied transform parms.
…rform the same operations on batch and non-batch compressed models
22 tasks
Rezmason
force-pushed
the
9402-batched-compression-phase-1
branch
from
December 26, 2023 19:25
e3fafa8
to
a03b325
Compare
…append LOD to batch-compressed output
Rezmason
force-pushed
the
9402-batched-compression-phase-1
branch
from
December 26, 2023 19:37
a03b325
to
c56f9c3
Compare
dinomut1
approved these changes
Dec 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
( Charlie and Jeremy's first big feature!✨ )
LOD_0
), 1024 (LOD_1
) and 512 (LOD_2
) are generated alongside the original file. (The selected model and the original GLTF/GLB are unchanged.)References
closes #9402
closes #9418
QA Steps
default project
.assets
folder, find the fileapartment.glb
, and drag it into the scene or into the Hierarchy panel. Wait for the model to load and appear.Model Transform Properties
section and expand it.Clientside Transform
checkbox is now checked by default.Batch Compress
.Batch Compress
and clickOptimize
.apartment-transformed-LOD_0.glb
,apartment-transformed-LOD_1.glb
andapartment-transformed-LOD_2.glb
appear in the panel.apartment-transformed-LOD_0.glb
,apartment-transformed-LOD_1.glb
andapartment-transformed-LOD_2.glb
. Do not deleteapartment.glb
.apartment.glb
and clickCompress
.apartment
, and that the UI contains an element namedModel Format
.COMPRESS
. Wait for the popup to close.apartment-transformed-LOD_0.glb
,apartment-transformed-LOD_1.glb
andapartment-transformed-LOD_2.glb
appear again in the panel. Delete them if you like.