This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixes for static-resources not updating in file-browser #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MoizAdnan
commented
Dec 25, 2023
MoizAdnan
commented
- Fixes static-resource table not removing entries of file which are inside a folder that is deleted
- Fixes static-resource table not updating paths of file which are inside a folder that is renamed or moved
hanzlamateen
approved these changes
Dec 26, 2023
HexaField
suggested changes
Dec 26, 2023
| if (staticResource?.data?.length > 0) await this.app.service(staticResourcePath).remove(staticResource?.data[0]?.id) | ||
| if (staticResources?.length > 0) { | ||
| for (const resource of staticResources) { | ||
| await this.app.service(staticResourcePath).remove(resource.id) |
There was a problem hiding this comment.
We should do this in parallel
| if (staticResources?.length > 0) { | ||
| for (const resource of staticResources) { | ||
| const newKey = resource.key.replace(path.join(_oldPath, data.oldName), path.join(_newPath, fileName)) | ||
| await this.app.service(staticResourcePath).patch( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.