merge hotfix

.gitignore

@@ -3,8 +3,6 @@
 *.user
 *.userosscache
 *.sln.docstates
-.idea/
-
 
 # Build results
 [Dd]ebug/
@@ -22,4 +20,4 @@ bld/
 *.opencover.xml
 
 #Visual studio cache/options directory
-.vs/
+.vs/

Changelog.md

@@ -10,6 +10,26 @@ https://github.com/Etherna/YoutubeExplode/releases
 
 # Changelog
 
+## v6.3.7 (09-Nov-2023)
+
+- [Converter] Fixed an issue where subtitles embedded via `VideoClient.DownloadAsync(...)` had their languages specified using ISO 639-1 codes instead of ISO 639-2 codes.
+
+## v6.3.6 (17-Oct-2023)
+
+- Fixed an issue where calling `VideoClient.GetAsync(...)` on certain videos failed with an exception due to recent YouTube changes.
+
+## v6.3.5 (28-Sep-2023)
+
+- Added support for parsing live video URLs (i.e. `youtube.com/live/...`). (Thanks [@eimigueloliveir](https://github.com/eimigueloliveir))
+
+## v6.3.4 (06-Sep-2023)
+
+- Fixed an issue where calling any method on `SearchClient` resulted in an exception on mobile devices. (Thanks [@jerry08](https://github.com/jerry08))
+
+## v6.3.3 (31-Aug-2023)
+
+- Fixed an issue where calling `ChannelClient.GetAsync(...)` and `PlaylistClient.GetAsync(...)` failed on some channels and playlists due to recent YouTube changes. (Thanks [@tmm360](https://github.com/tmm360))
+
 ## v6.3.2 (18-Aug-2023)
 
 - Fixed an issue where calling `StreamClient.GetManifestAsync(...)` failed on videos from the "YouTube Movies & TV" system channel.

Directory.Build.props

@@ -1,14 +1,16 @@
 <Project>
 
   <PropertyGroup>
-    <Company>Etherna Sagl</Company>
-    <Copyright>Copyright (C) Oleksii Holub, Copyright (C) 2023 Etherna Sagl</Copyright>
+    <Company>Etherna SA</Company>
+    <Copyright>Copyright (C) Oleksii Holub, Copyright (C) 2023 Etherna SA</Copyright>
     <LangVersion>latest</LangVersion>
     <Nullable>enable</Nullable>
-    <WarningsAsErrors>nullable</WarningsAsErrors>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <CheckEolTargetFramework>false</CheckEolTargetFramework>
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
     <IsPackable>false</IsPackable>
+
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
   <!-- Disable nullability warnings on frameworks where BCL is not annotated -->

LICENSE

@@ -4,7 +4,7 @@ YoutubeExplode
 Copyright (C) 2016-2023 Oleksii Holub
 
 Etherna YoutubeDownloader fork
-Copyright (C) 2023-present Etherna Sagl
+Copyright (C) 2023-present Etherna SA
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

Readme.md

@@ -122,6 +122,10 @@ var stream = await youtube.Videos.Streams.GetAsync(streamInfo);
 await youtube.Videos.Streams.DownloadAsync(streamInfo, $"video.{streamInfo.Container}");
 ```
 
+> **Warning**:
+> While the `Url` property in the stream metadata can be used to access the underlying content, you need a series of carefully crafted HTTP requests in order to do so.
+> It's highly recommended to use `Videos.Streams.GetAsync(...)` or `Videos.Streams.DownloadAsync(...)` instead, as they will all the heavy lifting for you.
+
 #### Downloading closed captions
 
 Closed captions can be downloaded in a similar way to media streams.

YoutubeDownloader.Converter.Tests/GeneralSpecs.cs

@@ -16,8 +16,7 @@ public class GeneralSpecs : IAsyncLifetime
 {
     private readonly ITestOutputHelper _testOutput;
 
-    public GeneralSpecs(ITestOutputHelper testOutput) =>
-        _testOutput = testOutput;
+    public GeneralSpecs(ITestOutputHelper testOutput) => _testOutput = testOutput;
 
     public async Task InitializeAsync() => await FFmpeg.InitializeAsync();
 
@@ -114,16 +113,23 @@ public async Task I_can_download_a_video_as_a_single_mp4_file_with_multiple_stre
             .Take(3)
             .ToArray();
 
-        await youtube.Videos.DownloadAsync(
-            videoStreamInfos.Concat<IStreamInfo>(audioStreamInfos).ToArray(),
-            new ConversionRequestBuilder(filePath).Build()
-        );
+        await youtube
+            .Videos
+            .DownloadAsync(
+                videoStreamInfos.Concat<IStreamInfo>(audioStreamInfos).ToArray(),
+                new ConversionRequestBuilder(filePath).Build()
+            );
 
         // Assert
         MediaFormat.IsMp4File(filePath).Should().BeTrue();
 
         foreach (var streamInfo in videoStreamInfos)
-            FileEx.ContainsBytes(filePath, Encoding.ASCII.GetBytes(streamInfo.VideoQuality.Label)).Should().BeTrue();
+        {
+            FileEx
+                .ContainsBytes(filePath, Encoding.ASCII.GetBytes(streamInfo.VideoQuality.Label))
+                .Should()
+                .BeTrue();
+        }
     }
 
     [Fact]
@@ -153,16 +159,23 @@ public async Task I_can_download_a_video_as_a_single_webm_file_with_multiple_str
             .Take(3)
             .ToArray();
 
-        await youtube.Videos.DownloadAsync(
-            videoStreamInfos.Concat<IStreamInfo>(audioStreamInfos).ToArray(),
-            new ConversionRequestBuilder(filePath).Build()
-        );
+        await youtube
+            .Videos
+            .DownloadAsync(
+                videoStreamInfos.Concat<IStreamInfo>(audioStreamInfos).ToArray(),
+                new ConversionRequestBuilder(filePath).Build()
+            );
 
         // Assert
         MediaFormat.IsWebMFile(filePath).Should().BeTrue();
 
         foreach (var streamInfo in videoStreamInfos)
-            FileEx.ContainsBytes(filePath, Encoding.ASCII.GetBytes(streamInfo.VideoQuality.Label)).Should().BeTrue();
+        {
+            FileEx
+                .ContainsBytes(filePath, Encoding.ASCII.GetBytes(streamInfo.VideoQuality.Label))
+                .Should()
+                .BeTrue();
+        }
     }
 
     [Fact]
@@ -175,11 +188,16 @@ public async Task I_can_download_a_video_using_custom_conversion_settings()
         var filePath = Path.Combine(dir.Path, "video.mp3");
 
         // Act
-        await youtube.Videos.DownloadAsync("9bZkp7q19f0", filePath, o => o
-            .SetFFmpegPath(FFmpeg.FilePath)
-            .SetContainer("mp4")
-            .SetPreset(ConversionPreset.UltraFast)
-        );
+        await youtube
+            .Videos
+            .DownloadAsync(
+                "9bZkp7q19f0",
+                filePath,
+                o =>
+                    o.SetFFmpegPath(FFmpeg.FilePath)
+                        .SetContainer("mp4")
+                        .SetPreset(ConversionPreset.UltraFast)
+            );
 
         // Assert
         MediaFormat.IsMp4File(filePath).Should().BeTrue();
@@ -208,4 +226,4 @@ public async Task I_can_download_a_video_while_tracking_progress()
         foreach (var value in progressValues)
             _testOutput.WriteLine($"Progress: {value:P2}");
     }
-}
+}

YoutubeDownloader.Converter.Tests/SubtitleSpecs.cs

@@ -36,17 +36,20 @@ public async Task I_can_download_a_video_as_a_single_mp4_file_with_subtitles()
         var trackInfos = trackManifest.Tracks;
 
         // Act
-        await youtube.Videos.DownloadAsync(
-            streamInfos,
-            trackInfos,
-            new ConversionRequestBuilder(filePath).Build()
-        );
+        await youtube
+            .Videos
+            .DownloadAsync(streamInfos, trackInfos, new ConversionRequestBuilder(filePath).Build());
 
         // Assert
         MediaFormat.IsMp4File(filePath).Should().BeTrue();
 
         foreach (var trackInfo in trackInfos)
-            FileEx.ContainsBytes(filePath, Encoding.ASCII.GetBytes(trackInfo.Language.Name)).Should().BeTrue();
+        {
+            FileEx
+                .ContainsBytes(filePath, Encoding.ASCII.GetBytes(trackInfo.Language.Name))
+                .Should()
+                .BeTrue();
+        }
     }
 
     [Fact]
@@ -70,16 +73,19 @@ public async Task I_can_download_a_video_as_a_single_webm_file_with_subtitles()
         var trackInfos = trackManifest.Tracks;
 
         // Act
-        await youtube.Videos.DownloadAsync(
-            streamInfos,
-            trackInfos,
-            new ConversionRequestBuilder(filePath).Build()
-        );
+        await youtube
+            .Videos
+            .DownloadAsync(streamInfos, trackInfos, new ConversionRequestBuilder(filePath).Build());
 
         // Assert
         MediaFormat.IsWebMFile(filePath).Should().BeTrue();
 
         foreach (var trackInfo in trackInfos)
-            FileEx.ContainsBytes(filePath, Encoding.ASCII.GetBytes(trackInfo.Language.Name)).Should().BeTrue();
+        {
+            FileEx
+                .ContainsBytes(filePath, Encoding.ASCII.GetBytes(trackInfo.Language.Name))
+                .Should()
+                .BeTrue();
+        }
     }
-}
+}

YoutubeDownloader.Converter.Tests/Utils/Extensions/HttpExtensions.cs

@@ -16,4 +16,4 @@ public static async Task DownloadAsync(this HttpClient http, string url, string
 
         await source.CopyToAsync(destination);
     }
-}
+}