feature #1 - update alb sg and subnets

Eugeniosales · Oct 16, 2022 · 120e387 · 120e387
1 parent ac1c467
commit 120e387
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 35 deletions.
diff --git a/terraform/env/dev.tfvars b/terraform/env/dev.tfvars
@@ -3,4 +3,4 @@ aws_profile = "dev"
 vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
 SUB_NET_01 = "subnet-05d245e39491bb3d2"
 SUB_NET_02 = "subnet-06761316782230c98"
-base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
+SG_ID = "sg-026d83888df8aa77d"
diff --git a/terraform/env/hml.tfvars b/terraform/env/hml.tfvars
@@ -3,4 +3,4 @@ aws_profile = "hml"
 vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
 SUB_NET_01 = "subnet-05d245e39491bb3d2"
 SUB_NET_02 = "subnet-06761316782230c98"
-base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
+SG_ID = "sg-026d83888df8aa77d"
diff --git a/terraform/env/prd.tfvars b/terraform/env/prd.tfvars
@@ -1,6 +1,6 @@
 ENV = "prd"
 aws_profile = "prd"
 vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
-SUB_NET_01 = "subnet-05d245e39491bb3d2"
-SUB_NET_02 = "subnet-06761316782230c98"
-base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
+SUB_NET_01 = "subnet-06761316782230c98"
+SUB_NET_02 = "subnet-052df03e273a7e04c"
+SG_ID = "sg-026d83888df8aa77d"
diff --git a/terraform/load-balance.tf b/terraform/load-balance.tf
@@ -2,7 +2,7 @@ resource "aws_lb" "lb-sbf-exchangerate" {
   name               = "sbf-exchangerate-${var.aws_profile}-lb"
   internal           = true
   load_balancer_type = "application"
-  security_groups    = [aws_security_group.lb.id]
+  security_groups    = [var.SG_ID]
   subnets            = [var.SUB_NET_01, var.SUB_NET_02]
 
   ip_address_type = "ipv4"

diff --git a/terraform/security-group.tf b/terraform/security-group.tf
diff --git a/terraform/variables.tf b/terraform/variables.tf
@@ -20,13 +20,14 @@ variable "SUB_NET_02" {
   default     = null
 }
 
-variable "base_url_internal" {
-  type = string
-  description = "base url internal for exchange rate microsservice"
-}
-
 variable "aws_profile" {
   type = string
   description = "AWS Profile"
   default = null
 }
+
+variable "SG_ID" {
+  type        = string
+  description = "security group id"
+  default     = null
+}