Skip to content

Commit

Permalink
feature #4 - remove route s3
Browse files Browse the repository at this point in the history
  • Loading branch information
Eugeniosales committed Oct 16, 2022
1 parent 4d4bedd commit f0dd329
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/terraform.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: 'Terraform CD'

on:
push:
branches: [ "main" ]
branches: [ "develop" ]
pull_request:

permissions:
Expand Down
3 changes: 1 addition & 2 deletions terraform/env/dev.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ aws_profile = "dev"
vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
SUB_NET_01 = "subnet-05d245e39491bb3d2"
SUB_NET_02 = "subnet-06761316782230c98"
base_url_internal = "http://exchangerate.internal.dev.sbf.com"
route53_zone_host = "internal.dev.sbf.com"
base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
3 changes: 1 addition & 2 deletions terraform/env/hml.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ aws_profile = "hml"
vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
SUB_NET_01 = "subnet-05d245e39491bb3d2"
SUB_NET_02 = "subnet-06761316782230c98"
base_url_internal = "http://exchangerate.internal.dev.sbf.com"
route53_zone_host = "internal.dev.sbf.com"
base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
3 changes: 1 addition & 2 deletions terraform/env/prd.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ aws_profile = "prd"
vpc_id = "vpc-0b1ae7a4fa0ec7d9d"
SUB_NET_01 = "subnet-05d245e39491bb3d2"
SUB_NET_02 = "subnet-06761316782230c98"
base_url_internal = "http://exchangerate.internal.dev.sbf.com"
route53_zone_host = "internal.dev.sbf.com"
base_url_internal = "internal-sbf-exchangerate-dev-lb-1838583828.us-east-1.elb.amazonaws.com"
9 changes: 0 additions & 9 deletions terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,3 @@ provider "aws" {
region = "us-east-1"
}

variable "route53_zone_host" {
type = string
description = "Route53 Zone Host"
}

data "aws_route53_zone" "selected" {
name = var.route53_zone_host
private_zone = true
}
15 changes: 0 additions & 15 deletions terraform/route53.tf

This file was deleted.

7 changes: 0 additions & 7 deletions terraform/ssm.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,3 @@ resource "aws_ssm_parameter" "exchange-rate-api-token-ssm" {
value = "custom"
overwrite = true
}

resource "aws_ssm_parameter" "exchange-rate-internal-url-ssm" {
name = "/exchangerate/infra/alb/arn"
type = "String"
value = "${var.base_url_internal}"
overwrite = true
}

0 comments on commit f0dd329

Please sign in to comment.