Refactor the Handler traits based on feedbacks on #188 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlevl
force-pushed
the
refactor/handler-traits
branch
from
ad14c64
to
de19052
Compare
lowlevl
force-pushed
the
refactor/handler-traits
branch
from
de19052
to
bf1df6e
Compare
lowlevl
force-pushed
the
refactor/handler-traits
branch
from
1f44fcb
to
ea3a228
Compare
|
Is there any update on this? Are you still working on it? |
|
Hi @ricott1, Unfortunately no, I got caught in the changes I wanted to make, rabbit-holed into making my own SSH library (which is not yet finished, https://github.com/lowlevl/assh) and forgot about this. |
|
Sure, but please note I don't have write privileges on this repository, so in fine it won't be me choosing if this gonna be merged :) |
|
Closing in favour of #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR based on the feedback received in #188, where I proposed some improvement on the overall API of the
russhcrate.