Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdh-sha2-nistp{256,384,521} kex support #282

Merged
merged 6 commits into from
May 10, 2024
Merged

Conversation

gleason-m
Copy link
Contributor

@gleason-m gleason-m commented May 10, 2024

Adds support for ecdh-sha2-nistp{256,384,521} key exchange algorithms using the elliptic-curve, p256, p384, and p521 crates.

Intentionally avoids adding these to the preferred Kex list as the security of these curves is considered controversial. Users would need to explicitly use the kex via config

Resolves #210

@Eugeny Eugeny merged commit 3bfd99f into Eugeny:main May 10, 2024
4 checks passed
@Eugeny
Copy link
Owner

Eugeny commented May 10, 2024

Well done 💪

@Eugeny
Copy link
Owner

Eugeny commented May 10, 2024

@all-contributors please add @gleason-m for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @gleason-m! 🎉

Eugeny pushed a commit that referenced this pull request May 10, 2024
Adds @gleason-m as a contributor for code.

This was requested by Eugeny [in this
comment](#282 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
EpicEric pushed a commit to EpicEric/russh that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ecdh-sha2-nistp256
2 participants