refactor: make clone_public_key
infallible
#365
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was wondering why
KeyPair::clone_public_key
was fallible.Turns out only the
RsaPrivate
->RsaPublic
conversion usedTryFrom
internally - aTryFrom
implementation that never failed and just returnedOk
, so it could just beFrom
.I've switched out
TryFrom
forFrom
and switched the Result type forclone_public_key
fromResult<T>
toT
.I've updated the tests and doctests touching
clone_public_key
to use the new signature so they all compile and pass again.The only argument I see right now not to change the signature would be for forward compatibility for key types where there actually is a sensible error scenario for extracting the public key, which I find hard to imagine. Please let me know if I'm being ignorant here 🤔
Best Regards