Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to reply to channel requests #381

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

qsantos
Copy link
Contributor

@qsantos qsantos commented Nov 17, 2024

See #156.

Using Rust typing system would be less error-prone. Maybe the pty-req case in server_read_authenticated could handle it in two ways:

  • call Handle::channel_success or Handle::channel_failure depending on the value returned by the handler;
  • always call Handle::channel_successafter calling the handler, assuming that, if the user callsHandle::channel_failure` in the handler, it will have priority; feels very hacky though.

@qsantos
Copy link
Contributor Author

qsantos commented Nov 17, 2024

Regarding the second part of my comment, I just realized that this is what #348 tries to do.

@Eugeny
Copy link
Owner

Eugeny commented Nov 17, 2024

Thanks! @all-contributors add @qsantos for docs

@Eugeny Eugeny merged commit 2dca3c6 into Eugeny:main Nov 17, 2024
6 checks passed
Copy link
Contributor

@Eugeny

I've put up a pull request to add @qsantos! 🎉

@qsantos qsantos deleted the doc-channel-success branch November 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants