Merge pull request #9624 from C41M50N/feature/hide-tray

add setting to hide tray (menubar for macos)
Eugeny · Jun 19, 2024 · db2280e · db2280e
2 parents c681902 + 8a49c73
commit db2280e
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 1 deletion.
diff --git a/app/lib/app.ts b/app/lib/app.ts
@@ -183,9 +183,10 @@ export class Application {
     }
 
     enableTray (): void {
-        if (!!this.tray || process.platform === 'linux') {
+        if (!!this.tray || process.platform === 'linux' || (this.configStore.hideTray ?? false) === true) {
             return
         }
+
         if (process.platform === 'darwin') {
             this.tray = new Tray(`${app.getAppPath()}/assets/tray-darwinTemplate.png`)
             this.tray.setPressedImage(`${app.getAppPath()}/assets/tray-darwinHighlightTemplate.png`)

diff --git a/locale/en-GB.po b/locale/en-GB.po
@@ -2036,6 +2036,10 @@ msgstr ""
 msgid "Show Serial connections"
 msgstr ""
 
+#: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:73
+msgid "Hide Tabby in tray or menu bar."
+msgstr ""
+
 #: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:152
 msgid "Show tabs in fullscreen mode"
 msgstr ""
@@ -2044,6 +2048,10 @@ msgstr ""
 msgid "Show toolbar"
 msgstr ""
 
+#: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:73
+msgid "Hide tray"
+msgstr ""
+
 #: locale/tmp-html/tabby-settings/src/components/vaultSettingsTab.component.html:45
 msgid "Show vault contents"
 msgstr ""

diff --git a/tabby-core/src/configDefaults.yaml b/tabby-core/src/configDefaults.yaml
@@ -43,6 +43,7 @@ enableWelcomeTab: true
 electronFlags:
   - ['force_discrete_gpu', '0']
 enableAutomaticUpdates: true
+hideTray: false
 version: 1
 vault: null
 encrypted: false

diff --git a/tabby-settings/src/components/windowSettingsTab.component.pug b/tabby-settings/src/components/windowSettingsTab.component.pug
@@ -121,6 +121,15 @@ h3.mb-3(translate) Window
         label.btn.btn-secondary(for='frameFull')
             span(translate) Full
 
+.form-line(*ngIf='hostApp.platform !== Platform.Web && hostApp.platform !== Platform.Linux')
+    .header
+        .title(translate) Hide tray
+        .description(translate) Hide Tabby in tray or menu bar.
+    toggle(
+        [(ngModel)]='config.store.hideTray',
+        (ngModelChange)='saveConfiguration(true)'
+    )
+
 h3.mt-4(translate) Docking
 
 .form-line(*ngIf='docking')