Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funny but annoying Backspace issue in Profiles & connections #8915

Closed
konstantin83 opened this issue Sep 2, 2023 · 3 comments · Fixed by #8960
Closed

Funny but annoying Backspace issue in Profiles & connections #8915

konstantin83 opened this issue Sep 2, 2023 · 3 comments · Fixed by #8960
Labels

Comments

@konstantin83
Copy link

konstantin83 commented Sep 2, 2023

Hey, Eugeny.
My Tabby version is 1.0.196 (the last actual version from apt repository).
In Profile & connection popup you can start typing a name of the profile to quickly connect to it. But if you made a mistake and want to delete everything, you hold the Backspace key expecting it to stop at the end of the line, when all characters are deleted. But it's not.
If you press or hold Backspace key It doesn't stop and instead somehow pastes a name of a recent profile and continues to delete it, until reaches the last characted, and then it happens again infinitely.

Here's the video with keypresses indicator at the bottom for clearity.

2023-09-02-08.26.36.792980445.mp4
@Clem-Fern
Copy link
Contributor

Hey, I agree. It can be quite annoying. It is cause by the edit feature which insert the quick connect string of the selected profile when Backspace key is pressed.

I think it could be a great idea to prevent entering edit as long as the Backspace key is pressed.
I will submit a PR about this in the next few days.

@konstantin83
Copy link
Author

@Clem-Fern Thanks for the reply. Have you already submitted a PR about this issue?
Can I somehow track such changes this to know if they are in a new version?

@Clem-Fern
Copy link
Contributor

Clem-Fern commented Sep 10, 2023

Hi @konstantin83,
Just opened a PR about this, I didn't get the time to do it before sorry.

You can watch the project to be aware of a new release:
image
Nightly build will also contain this fix once PR merged, you can used it in wait of a the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants